Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netty-dev-tools - No license in pom #13787

Open
nmck257 opened this issue Jan 17, 2024 · 2 comments · Fixed by #13798
Open

netty-dev-tools - No license in pom #13787

nmck257 opened this issue Jan 17, 2024 · 2 comments · Fixed by #13798
Milestone
4.1.110.Final

Comments

@nmck257
Copy link

nmck257 commented Jan 17, 2024

The poms for the netty-parent and netty-bom include the license field, and (almost) every other module uses netty-parent as its parent, and so the license metadata is inherited in the effective pom.

But, netty-dev-tools uses oss-parent as its parent directly, and does not declare its license in the pom. This can cause ambiguity in the licensing of the published Maven artifact..

It would be nice to paste the license element into netty-dev-tools/pom.xml.
normanmaurer added a commit that referenced this issue Jan 21, 2024
@normanmaurer
netty-dev-tools use wrong parent pom
6a4e4df 
Motivation:

netty-dev-tools used the wrong parent pom and so did not include all the license infos etc.

Modifications:

Declare the correct parent pom

Result:

Fixes #13787
@normanmaurer normanmaurer mentioned this issue Jan 21, 2024
Merged
@normanmaurer
Copy link
Member

@nmck257 thanks for reporting ... I think we should just use the correct parent pom:

#13798

@normanmaurer normanmaurer added this to the 4.1.107.Final milestone Jan 21, 2024
@nmck257
Copy link
Author

nmck257 commented Jan 21, 2024

That works too! Wasn't sure if there was some intention behind the separate parent

normanmaurer added a commit that referenced this issue Jan 22, 2024
@normanmaurer
netty-dev-tools use wrong parent pom (#13798)
b52acfe 
Motivation:

netty-dev-tools used the wrong parent pom and so did not include all the
license infos etc.

Modifications:

Declare the correct parent pom

Result:

Fixes #13787
normanmaurer added a commit that referenced this issue Jan 22, 2024
@normanmaurer
netty-dev-tools use wrong parent pom (#13798)
dee995e 
Motivation:

netty-dev-tools used the wrong parent pom and so did not include all the
license infos etc.

Modifications:

Declare the correct parent pom

Result:

Fixes #13787
franz1981 pushed a commit to franz1981/netty that referenced this issue Feb 9, 2024
@normanmaurer @franz1981
netty-dev-tools use wrong parent pom (netty#13798)
12fbaa0 
Motivation:

netty-dev-tools used the wrong parent pom and so did not include all the
license infos etc.

Modifications:

Declare the correct parent pom

Result:

Fixes netty#13787
@normanmaurer normanmaurer reopened this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.110.Final
Development

Successfully merging a pull request may close this issue.

netty-dev-tools use wrong parent pom netty/netty
2 participants
@normanmaurer @nmck257