HttpStaticFileServerHandler Example: Fail to download file in ssl mode

[bobwenx]

The netty http-file-server example are unable to download file if ssl mode is enabled:

sh run-example.sh -Dssl http-file-server               
[INFO] Running: http-file-server (io.netty.example.http.file.HttpStaticFileServer -D_ -Dssl)
19:25:32.426 [nioEventLoopGroup-0-0] INFO  i.n.handler.logging.LoggingHandler - [id: 0x88c83b40] REGISTERED
19:25:32.430 [nioEventLoopGroup-0-0] INFO  i.n.handler.logging.LoggingHandler - [id: 0x88c83b40] BIND: 0.0.0.0/0.0.0.0:8443
Open your web browser and navigate to https://127.0.0.1:8443/
19:25:32.434 [nioEventLoopGroup-0-0] INFO  i.n.handler.logging.LoggingHandler - [id: 0x88c83b40, /0:0:0:0:0:0:0:0:8443] ACTIVE

when i try to download file(https://localhost:8443/pom.xml) with chrome, the browser will hang there:
HTTP Request:

Accept:text/html,application/xhtml+xml,application/xml;q=0.9,image/webp,*/*;q=0.8
User-Agent:Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/41.0.2272.76 Safari/537.36
X-FirePHP-Version:0.0.6

HTTP Response:

pending...

i check the example code, and find the comment(line 200) say:

// HttpChunkedInput will write the end marker (LastHttpContent) for us.
lastContentFuture = sendFileFuture;

However, it didn't write HTTP end marker(that's why the browser hang).

if i change the code to manually write LastHttpContent.EMPTY_LAST_CONTENT, Chrome can download file correctly.

// Line 196
response.headers().set(TRANSFER_ENCODING, HttpHeaderValues.CHUNKED);
sendFileFuture =  ctx.write(new HttpChunkedInput(new ChunkedFile(raf, 0, fileLength, 8192)), 
                                          ctx.newProgressivePromise());
// HttpChunkedInput will write the end marker (LastHttpContent) for us.
// lastContentFuture = sendFileFuture;
lastContentFuture = ctx.writeAndFlush(LastHttpContent.EMPTY_LAST_CONTENT);

So, There are something wrong in HttpChunkedInput processing?

[normanmaurer]

@bobwenx nope the code of the example is wrong. Could you try to replace:

ctx.write(new HttpChunkedInput(...));

with

ctx.writeAndFlush(new HttpChunkedInput(...));

and let me know if it works ?

[bobwenx]

after change code to use writeAndFlush, it works as expected! Chrome can download file correctly.

One more thing, the javadoc of HttpChunkedInput says:

...
Ensure that your HTTP response header contains {@code Transfer-Encoding: chunked}.

However, the HTTP response didn't contains such header:

cache-control:private, max-age=60
connection:keep-alive
content-length:4787
content-type:application/octet-stream
date:Wed, 08 Apr 2015 10:22:12 GMT
expires:Wed, 08 Apr 2015 10:23:12 GMT
last-modified:Sat, 04 Apr 2015 17:47:57 GMT

do we need manually add such header?

// Line 196
response.headers().set(TRANSFER_ENCODING, HttpHeaderValues.CHUNKED);
sendFileFuture = ctx.writeAndFlush(new HttpChunkedInput(new ChunkedFile(raf, 0, fileLength, 8192)),
                            ctx.newProgressivePromise());
// HttpChunkedInput will write the end marker (LastHttpContent) for us.
lastContentFuture = sendFileFuture;

[normanmaurer]

Fixed.. Thanks for reporting