OioSctpChannel read iterating over selected keys #3884
Comments
|
/cc @jestan |
|
@jestan - Any objections to me removing this code? |
|
@Scottmitch Please go ahead. We can't wait forever. |
|
@trustin - Will do :) |
Scottmitch
added a commit
to Scottmitch/netty
that referenced
this issue
Aug 26, 2015
Motivation: OioSctpChannel.doReadMessages is iterating over the selected keys, and ignoring each selected key. It is not known why this is needed and no other channel implementation does this. Modifications: - Stop iterating over selected keys, and just read like other channels Result: No unnecessary iteration in OioSctpChannel.doReadMessages. Fixes netty#3884
Scottmitch
added a commit
that referenced
this issue
Aug 27, 2015
Motivation: OioSctpChannel.doReadMessages is iterating over the selected keys, and ignoring each selected key. It is not known why this is needed and no other channel implementation does this. Modifications: - Stop iterating over selected keys, and just read like other channels Result: No unnecessary iteration in OioSctpChannel.doReadMessages. Fixes #3884
Scottmitch
added a commit
that referenced
this issue
Aug 27, 2015
Motivation: OioSctpChannel.doReadMessages is iterating over the selected keys, and ignoring each selected key. It is not known why this is needed and no other channel implementation does this. Modifications: - Stop iterating over selected keys, and just read like other channels Result: No unnecessary iteration in OioSctpChannel.doReadMessages. Fixes #3884
Apache9
added a commit
to Apache9/netty
that referenced
this issue
Dec 21, 2015
Motivation: The fix for netty#3884 breaks SctpEchoTest because Selector.select will always return 0 if you do not clear last selectedKeys. Modifications: Clear readSelector.selectedKeys() if it is not empty. Result: SctpEchoTest is green again.
normanmaurer
pushed a commit
that referenced
this issue
Dec 21, 2015
Motivation: The fix for #3884 breaks SctpEchoTest because Selector.select will always return 0 if you do not clear last selectedKeys. Modifications: Clear readSelector.selectedKeys() if it is not empty. Result: SctpEchoTest is green again.
normanmaurer
pushed a commit
that referenced
this issue
Dec 21, 2015
Motivation: The fix for #3884 breaks SctpEchoTest because Selector.select will always return 0 if you do not clear last selectedKeys. Modifications: Clear readSelector.selectedKeys() if it is not empty. Result: SctpEchoTest is green again.
pulllock
pushed a commit
to pulllock/netty
that referenced
this issue
Oct 19, 2023
Motivation: OioSctpChannel.doReadMessages is iterating over the selected keys, and ignoring each selected key. It is not known why this is needed and no other channel implementation does this. Modifications: - Stop iterating over selected keys, and just read like other channels Result: No unnecessary iteration in OioSctpChannel.doReadMessages. Fixes netty#3884
pulllock
pushed a commit
to pulllock/netty
that referenced
this issue
Oct 19, 2023
Motivation: The fix for netty#3884 breaks SctpEchoTest because Selector.select will always return 0 if you do not clear last selectedKeys. Modifications: Clear readSelector.selectedKeys() if it is not empty. Result: SctpEchoTest is green again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm curious why the OioSctpChannel is iterating over
readSelector.selectedKeys()but not using theSelectionKey. It seems like the assumption is the number of keys that are active is an indication of how many read operation should be done?The text was updated successfully, but these errors were encountered: