Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AbstractNioWorker should create Selector in constructor #582

Closed
normanmaurer opened this issue Sep 3, 2012 · 2 comments
Closed

AbstractNioWorker should create Selector in constructor #582

normanmaurer opened this issue Sep 3, 2012 · 2 comments
Assignees
@normanmaurer
Labels
cleanup improvement
Milestone
3.5.7.Final

Comments

@normanmaurer
Copy link
Member

At the moment we "lazy" create the Selector on AbstractNioWorker once a Channel was registered. I think it would make more sense to just create it in the constructor, this will also free us from some synchronzation and race-condition.

This should also fix: #395
@ghost ghost assigned normanmaurer Sep 3, 2012
normanmaurer added a commit that referenced this issue Sep 3, 2012
@normanmaurer
Don't create Selector in a lazy fashion, just create it in the constr…
64b9e8f 
…uctor. See #582
normanmaurer added a commit that referenced this issue Sep 4, 2012
@normanmaurer
Throw an RejectedExecutionException if someone tries to register a Ch…
3d44182 
…annel to an AbstractNioWorker that was shutdown before. Part of #582
@normanmaurer
Copy link
Member Author

@trustin is this change to redical for a x.x.x release ? Maybe we should make the next release 3.6.0.Final ?

@trustin
Copy link
Member

trustin commented Sep 4, 2012

I think it's not that radical. :-)

@normanmaurer normanmaurer mentioned this issue Oct 23, 2012
Closed
@normanmaurer normanmaurer mentioned this issue Apr 1, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normanmaurer normanmaurer

Labels
cleanup improvement
Projects
None yet
Milestone
3.5.7.Final
Development

No branches or pull requests
2 participants
@trustin @normanmaurer