Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup work around for JDK's SSLEngine not throwing SSLHandshakeException #6421

Open
Scottmitch opened this issue Feb 20, 2017 · 2 comments

Comments

@Scottmitch
Copy link
Member

Expected behavior

When a TLS/SSL handshake is failed it is expected that the SSLEngine will throw a SSLHandshakeException. We have added some work arounds in unit tests to allow for non SSLHandshakeException so the unit tests will pass. We should remove these workarounds after the issue is addressed.

Actual behavior

The JDK's implementation of SSLEngine does not always do this.

Steps to reproduce

Run JdkOpenSslEngineInteroptTest and JdkOpenSslEngineInteroptTest but also remove the mySetupMutualAuthServerIsValidServerException and mySetupMutualAuthServerIsValidClientException methods.

Netty version

4.1.9

JVM version (e.g. java -version)

java version "1.8.0_112"
Java(TM) SE Runtime Environment (build 1.8.0_112-b16)
Java HotSpot(TM) 64-Bit Server VM (build 25.112-b16, mixed mode)

OS version (e.g. uname -a)

macOS Sierra 10.12.3

@Scottmitch
Copy link
Member Author

Related #6421

@Scottmitch
Copy link
Member Author

@normanmaurer - please link the JDK issue here when it is created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant