-
-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
memory leak #8765
Comments
@zyb2013 you are right we are not consistent here... I wonder which implementation is more correct tho. @ejona86 @carl-mastrangelo @trustin WDYT ? |
And @Scottmitch |
Since We could also consider moving the cleanup code into the |
…n calling write(...) / writeAndFlush(...) Motivation: We need to release the message when we throw an IllegalArgumentException because of a validation failure of the promise to eliminate the risk of a memory leak. Modifications: - Consistently release the message before rethrow - Add testcase. Result: Fixes #8765.
Existing code that called writeAndFlush would wrap it correct? |
…n calling write(...) / writeAndFlush(...) (#8769) Motivation: We need to release the message when we throw an IllegalArgumentException because of a validation failure of the promise to eliminate the risk of a memory leak. Modifications: - Consistently release the message before rethrow - Add testcase. Result: Fixes #8765.
…n calling write(...) / writeAndFlush(...) (#8769) Motivation: We need to release the message when we throw an IllegalArgumentException because of a validation failure of the promise to eliminate the risk of a memory leak. Modifications: - Consistently release the message before rethrow - Add testcase. Result: Fixes #8765.
In first picture,the code have no surround with try..catch.If here occurs RuntimeException,does it mean msg will not be released?
The text was updated successfully, but these errors were encountered: