Fix regression when trying to bind an EpollDatagramChannel with port #10552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only Motivation: 4b7dba1 introduced a change which was not 100 % complete and so introduce a regression when a user specified to use InetProtocolFamily.IPv4 and trying to bind to a port (without specify the ip). Modifications: - Fix regression by respect the InetProtocolFamily - Add unit test Result: Fix regression when binding to port explicit
normanmaurer
requested review from
carl-mastrangelo,
chrisvest and
franz1981
hyperxpro
approved these changes
Sep 9, 2020
|
@hyperxpro you can workaround this by using |
chrisvest
approved these changes
Sep 9, 2020
normanmaurer
added a commit
that referenced
this pull request
Sep 9, 2020
…10552) only Motivation: 4b7dba1 introduced a change which was not 100 % complete and so introduce a regression when a user specified to use InetProtocolFamily.IPv4 and trying to bind to a port (without specify the ip). Modifications: - Fix regression by respect the InetProtocolFamily - Add unit test Result: Fix regression when binding to port explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only
Motivation:
4b7dba1 introduced a change which was not 100 % complete and so
introduce a regression when a user specified to use
InetProtocolFamily.IPv4 and trying to bind to a port (without specify
the ip).
Modifications:
Result:
Fix regression when binding to port explicit