Ensure IovArray is usuable without sun.misc.Unsafe #10870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
changed the title
normanmaurer
force-pushed
the
memory_address_fix_again
branch
from
a05ec92
to
d1d2eeb
Compare
|
The motivation in the PR and commit is incomplete. |
chrisvest
approved these changes
Dec 16, 2020
Motivation: #10814 did fix a bug where we did try to call memoryAddress() even tho this is not supported. Unfortunally this fix was only applied for one method and so we missed another method which then could throw an exception when we called memoryAddress() Modifications: - Also fix the memoryAddress(offset) method. _ Adjust unit test to also test this. Result: Fixes #10813 completely.
normanmaurer
force-pushed
the
memory_address_fix_again
branch
from
d1d2eeb
to
e7c353e
Compare
|
@chrisvest not sure how this happened... done :/ |
chrisvest
approved these changes
Dec 16, 2020
normanmaurer
added a commit
that referenced
this pull request
Dec 16, 2020
Motivation: #10814 did fix a bug where we did try to call memoryAddress() even tho this is not supported. Unfortunally this fix was only applied for one method and so we missed another method which then could throw an exception when we called memoryAddress() Modifications: - Also fix the memoryAddress(offset) method. _ Adjust unit test to also test this. Result: Fixes #10813 completely.
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: netty#10814 did fix a bug where we did try to call memoryAddress() even tho this is not supported. Unfortunally this fix was only applied for one method and so we missed another method which then could throw an exception when we called memoryAddress() Modifications: - Also fix the memoryAddress(offset) method. _ Adjust unit test to also test this. Result: Fixes netty#10813 completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#10814 did fix a bug where we did try to call memoryAddress() even tho this is not supported. Unfortunally this fix was only applied for one method and so we missed another method which then could throw an exception when we called memoryAddress()
Modifications:
Result:
Fixes #10813 completely.