Fix race when handling delegating tasks in ReferenceCountedOpenSslEngine #12149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Due incorrect handling of delegating tasks in ReferenceCountedOpenSslEngine it was possible to observe handshake timeouts / failures. Modification: - Only reset needsTask variable after we actually ran the task. - Add missing synchronized as otherwise we might end up calling native code concurrently which is not safe. - Change how we excute delegating tasks in our SSLEngineTest. This change would result in timeouts / failures before the fix. Result: Fixes #12139
This was referenced Mar 8, 2022
|
@chrisvest I opened a PR against 4.1 and main to proof that for both cases all works. |
chrisvest
approved these changes
Mar 8, 2022
johnou
reviewed
Mar 8, 2022
| @@ -1475,19 +1469,22 @@ public void run() { | |||
| public void run(final Runnable runnable) { | |||
| if (isDestroyed()) { | |||
| // The engine was destroyed in the meantime, just return. | |||
| runnable.run(); | |||
There was a problem hiding this comment.
@normanmaurer intentionally not running the runnable in this refactor if the engine is destroyed?
There was a problem hiding this comment.
Yes as the SSL object is already destroyed
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…ine (netty#12149) Motivation: Due incorrect handling of delegating tasks in ReferenceCountedOpenSslEngine it was possible to observe handshake timeouts / failures. Modification: - Only reset needsTask variable after we actually ran the task. - Add missing synchronized as otherwise we might end up calling native code concurrently which is not safe. - Change how we excute delegating tasks in our SSLEngineTest. This change would result in timeouts / failures before the fix. Result: Fixes netty#12139
franz1981
pushed a commit
to franz1981/netty
that referenced
this pull request
Aug 22, 2022
…ine (netty#12149) Motivation: Due incorrect handling of delegating tasks in ReferenceCountedOpenSslEngine it was possible to observe handshake timeouts / failures. Modification: - Only reset needsTask variable after we actually ran the task. - Add missing synchronized as otherwise we might end up calling native code concurrently which is not safe. - Change how we excute delegating tasks in our SSLEngineTest. This change would result in timeouts / failures before the fix. Result: Fixes netty#12139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Due incorrect handling of delegating tasks in ReferenceCountedOpenSslEngine it was possible to observe handshake timeouts / failures.
Modification:
Result:
Fixes #12139