Fix race condition in setting ReferenceCountedOpenSslEngine.needTask flag #12140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12139
What's changed
This PR reorders resetting
ReferenceCountedOpenSslEngine.needTask
flag within theio.netty.handler.ssl.ReferenceCountedOpenSslEngine.TaskDecorator.run()
method. The flag shouldn't be unset before the task execution finishes.What's not changed
This PR doesn't change the
needTask
flag handling inAsyncTask
s. I'm not sure when and how this type is used.There could be also a problem if more tasks are allowed to be returned for subsequent
getDelegatedTask()
call.Then the single
boolean
variable is not enough to track task processing. It would rather deserve a task counter.