Commits on Nov 9, 2022

1. Move validation of connection headers in HTTP/2 back to HpackDecoder …

   Motivation:
   
   netty#12755 added validation for presence of connection-related headers while
   `HpackDecoder` decodes the incoming frame. Then netty#12832 moved this
   validation from `HpackDecoder` to `DefaultHttp2Headers`. As the result,
   existing use-case that could use `DefaultHttp2Headers` for HTTP/2 and
   HTTP/1.X broke when users add  any of the mentioned prohibited headers.
   The HTTP/1.X to HTTP/2 translation logic usually has sanitization
   process that removes connection-related headers. It's enough to run this
   validation only for incoming messages and we should preserve backward
   compatibility for 4.1.
   
   Modifications:
   
   - Move `isConnectionHeader` and `te` validations from
   `DefaultHttp2Headers` back to `HpackDecoder`;
   - Add tests to verify `HpackDecoder` fails incoming headers as
   expected;
   - Add tests to verify mentioned headers can be added to
   `DefaultHttp2Headers`;
   
   Result:
   
   Backward compatibility is preserved, while validation for
   connection-related headers is done in `HpackDecoder`.

   

   idelpivnitskiy committed Nov 9, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 83bd4ad
   • Browse repository at this point

   Copy the full SHA

   83bd4ad View commit details

   Browse the repository at this point in the history