Enhance CertificateException message when throw due hostname validation #13381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idelpivnitskiy
requested changes
May 15, 2023
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Show resolved
Hide resolved
handler/src/test/java/io/netty/handler/ssl/EnhancedX509ExtendedTrustManagerTest.java
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
May 22, 2023
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Outdated
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Outdated
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Outdated
Show resolved
Hide resolved
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Show resolved
Hide resolved
Motivation: It is hard for end-user to understand why the hostname validation failed. Let's try to help them by including the SubjectAlternativeNames if there are any. Modifications: - Wrap the X509ExtendedTrustManager and so be able to catch the CertificateException and add more details if needed - Add unit test Result: Easier to debug hostname validation problems
normanmaurer
force-pushed
the
cert_exception
branch
from
23e6fde
to
4b30188
Compare
idelpivnitskiy
approved these changes
Jul 19, 2023
handler/src/main/java/io/netty/handler/ssl/EnhancingX509ExtendedTrustManager.java
Show resolved
Hide resolved
normanmaurer
added a commit
that referenced
this pull request
Jul 19, 2023
…on (#13381) Motivation: It is hard for end-user to understand why the hostname validation failed. Let's try to help them by including the SubjectAlternativeNames if there are any. Modifications: - Wrap the X509ExtendedTrustManager and so be able to catch the CertificateException and add more details if needed - Add unit test Result: Easier to debug hostname validation problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It is hard for end-user to understand why the hostname validation failed. Let's try to help them by including the SubjectAlternativeNames if there are any.
Modifications:
Result:
Easier to debug hostname validation problems