Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance CertificateException message when throw due hostname validation #13381

Merged
merged 3 commits into from
Jul 19, 2023
Merged

Enhance CertificateException message when throw due hostname validation #13381

merged 3 commits into from
Jul 19, 2023

Commits on Jul 19, 2023

  1. Enhance CertificateException message when throw due hostname validation 

    Motivation:

It is hard for end-user to understand why the hostname validation failed. Let's try to help them by including the SubjectAlternativeNames if there are any.

Modifications:

- Wrap the X509ExtendedTrustManager and so be able to catch the CertificateException and add more details if needed
- Add unit test

Result:

Easier to debug hostname validation problems
    @normanmaurer
    normanmaurer committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    7db5e44 View commit details
    Browse the repository at this point in the history

  2. Address feedback

    @normanmaurer
    normanmaurer committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    08eb636 View commit details
    Browse the repository at this point in the history

  3. Address comments

    @normanmaurer
    normanmaurer committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    4b30188 View commit details
    Browse the repository at this point in the history