ReadOnlyByteBufferBuf | ReadOnlyUnsafeDirectByteBuf get*, copy*, dupl… #14072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icate*, slice* methods should be safe to be called from multiple threads. Motivation: Get* operations should always be safe to be used from different Threads. Modifications: - Only use internalNioBuffer when one of the read* or write* mthods are used. This is neccessary to prevent races as those can happen when a slice or duplicate is shared between different Channels - Add unit tests Result: Fixes #14070. Related to #1865
|
PTAL @lhotari |
lhotari
approved these changes
May 23, 2024
normanmaurer
added a commit
that referenced
this pull request
May 23, 2024
#14072) …icate*, slice* methods should be safe to be called from multiple threads. Motivation: Get* operations should always be safe to be used from different Threads. Modifications: - Only use internalNioBuffer when one of the read* or write* mthods are used. This is neccessary to prevent races as those can happen when a slice or duplicate is shared between different Channels - Add unit tests Result: Fixes #14070. Related to #1865
This was referenced May 25, 2024
normanmaurer
added a commit
to yawkat/netty
that referenced
this pull request
Jul 17, 2024
netty#14072) …icate*, slice* methods should be safe to be called from multiple threads. Motivation: Get* operations should always be safe to be used from different Threads. Modifications: - Only use internalNioBuffer when one of the read* or write* mthods are used. This is neccessary to prevent races as those can happen when a slice or duplicate is shared between different Channels - Add unit tests Result: Fixes netty#14070. Related to netty#1865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…icate*, slice* methods should be safe to be called from multiple threads.
Motivation:
Get* operations should always be safe to be used from different Threads.
Modifications:
Result:
Fixes #14070. Related to #1865