Resurrect Channel.id() with global uniqueness #1983
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
trustin
commented
Nov 15, 2013
trustin
commented
- Add a new interface ChannelId and its default implementation which generates globally unique channel ID.
- Replace AbstractChannel.hashCode with ChannelId.hashCode() and ChannelId.shortValue()
| @@ -324,7 +356,7 @@ public static ByteBuf encodeString(ByteBufAllocator alloc, CharBuffer src, Chars | |||
| if (!cr.isUnderflow()) { | |||
| cr.throwException(); | |||
| } | |||
| dst.writerIndex(dst.writerIndex() + (dstBuf.position() - pos)); | |||
| dst.writerIndex(dst.writerIndex() + dstBuf.position() - pos); | |||
| release = false; | |||
| return dst; | |||
| } catch (CharacterCodingException x) { | |||
There was a problem hiding this comment.
Could you commit this as a separate thing as it's not related ?
- Add a new interface ChannelId and its default implementation which generates globally unique channel ID. - Replace AbstractChannel.hashCode with ChannelId.hashCode() and ChannelId.shortValue() - Add variants of ByteBuf.hexDump() which accept byte[] instead of ByteBuf.
|
@trustin looks good. go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.