Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

microbench: move caliper to jmh #2085

Closed
wants to merge 4 commits into from
Closed

microbench: move caliper to jmh #2085

wants to merge 4 commits into from

Conversation

daschl
Copy link
Member

@daschl daschl commented Dec 23, 2013

Not a WIP anymore!

since it has junit support as before, you can run it from your IDE (but only class-level, not method level).. or from the command line through mvn -DskipTests=false test.

Happy christmas :)

@daschl
Copy link
Member Author

daschl commented Dec 23, 2013

@trustin @normanmaurer would be cool if you can try it and give me feedback what to improve aside from the things I need to add shown above.

@ghost
Copy link

ghost commented Dec 23, 2013

Build result for #2085 at 39e773dfb1f76f92972773129ef493da4e4ff0a7: Success

@ghost
Copy link

ghost commented Dec 23, 2013

Build result for #2085 at 2e7ca15956a46f9dfda214dee1b39a8018ff07f2: Success

@daschl
Copy link
Member Author

daschl commented Dec 23, 2013

now json reports are generated in target/reports/performance for each class.. also fork, warmup iter and run iters can be defined through properties (defaults set)

@ghost
Copy link

ghost commented Dec 23, 2013

Build result for #2085 at fa2dd587d251533ddabb9cac861c783d02c5e1a4: Success

@daschl
Copy link
Member Author

daschl commented Dec 23, 2013

from my perspective this is good enough for merging, of course looking for review :) (so formally no WIP anymore)

@daschl
Copy link
Member Author

daschl commented Jan 9, 2014

@trustin @normanmaurer now that you guys are back from holidays, I'm curious what you think hehe

private final ByteBufAllocator pooledDirectAllocator = new PooledByteBufAllocator(true);

@GenerateMicroBenchmark
public void unpooledHeapAllocAndFree_1_0() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way to parameterize this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with Aleksey Shipilev and there is no built-in way like with caliper.. You could do some hand crafted code, but there is one benefit here:

the output looks very nice, because it is sorted properly.. If we just have one method name (or a few), the results wouldnt be as pretty.

@ghost
Copy link

ghost commented Jan 10, 2014

Build result for #2085 at 5a7df65: Success

This was referenced Jan 13, 2014
@trustin
Copy link
Member

trustin commented Jan 14, 2014

Squashed and merged via 7879005. Thanks a lot, @daschl !

@trustin trustin closed this Jan 14, 2014
@ghost ghost assigned trustin Jan 14, 2014
@normanmaurer
Copy link
Member

+1

-- 
Norman Maurer

An 14. Januar 2014 at 07:34:57, Trustin Lee (notifications@github.com) schrieb:

Squashed and merged via 7879005. Thanks a lot, @daschl !


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants