-
-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
microbench: move caliper to jmh #2085
Conversation
@trustin @normanmaurer would be cool if you can try it and give me feedback what to improve aside from the things I need to add shown above. |
now json reports are generated in target/reports/performance for each class.. also fork, warmup iter and run iters can be defined through properties (defaults set) |
from my perspective this is good enough for merging, of course looking for review :) (so formally no WIP anymore) |
@trustin @normanmaurer now that you guys are back from holidays, I'm curious what you think hehe |
private final ByteBufAllocator pooledDirectAllocator = new PooledByteBufAllocator(true); | ||
|
||
@GenerateMicroBenchmark | ||
public void unpooledHeapAllocAndFree_1_0() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to parameterize this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked with Aleksey Shipilev and there is no built-in way like with caliper.. You could do some hand crafted code, but there is one benefit here:
the output looks very nice, because it is sorted properly.. If we just have one method name (or a few), the results wouldnt be as pretty.
+1 -- An 14. Januar 2014 at 07:34:57, Trustin Lee (notifications@github.com) schrieb: Squashed and merged via 7879005. Thanks a lot, @daschl ! — |
Not a WIP anymore!
since it has junit support as before, you can run it from your IDE (but only class-level, not method level).. or from the command line through
mvn -DskipTests=false test
.Happy christmas :)