-
-
Notifications
You must be signed in to change notification settings - Fork 15.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to recv and send file descriptors when using EpollDomainSocketChan... #3345
Conversation
@trustin please review |
|
||
descriptorMessage.msg_control = control; | ||
descriptorMessage.msg_controllen = sizeof(control); | ||
struct cmsghdr *cmsg = CMSG_FIRSTHDR(&descriptorMessage); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle reminder on consistent asterisk position :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
First pass done. Please ping me for another pass. |
c9963a3
to
8b5f6a0
Compare
@trustin ping :) |
217e176
to
5f2be6a
Compare
8b5f6a0
to
099b333
Compare
…hannel. Motiviation: When using domain sockets on linux it is supported to recv and send file descriptors. This can be used to pass around for example sockets. Modifications: - Add support for recv and send file descriptors when using EpollDomainSocketChannel. - Allow to obtain the file descriptor for an Epoll*Channel so it can be send via domain sockets. Result: recv and send of file descriptors is supported now.
099b333
to
e77d683
Compare
} | ||
|
||
if (res < 0) { | ||
return -err; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we could merge the two if
s:
if (res <= 0) {
return -err;
}
...nel.
Motiviation:
When using domain sockets on linux it is supported to recv and send file descriptors. This can be used to pass around for example sockets.
Modifications:
Result:
recv and send of file descriptors is supported now.