Correctly set the alert type depending of the CertificateException #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nmittler @Scottmitch PTAL... This depends on netty/netty-tcnative#117 |
|
LGTM |
1 similar comment
|
LGTM |
normanmaurer
force-pushed
the
ssl_cert_error
branch
from
6e8dde4
to
450e52c
Compare
|
+1 for |
normanmaurer
force-pushed
the
ssl_cert_error
branch
2 times, most recently
from
7948f35
to
175ac2b
Compare
Motivation: Depending on the actual CertificateException we should set the correct alert type so it will be sent back to the remote peer and so make it easier for them to fix it. Modification: Correctly set the alert and not always just use a general alert. Result: It's easier for the remote peer to fix the problems.
normanmaurer
force-pushed
the
ssl_cert_error
branch
from
175ac2b
to
537332f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Depending on the actual CertificateException we should set the correct alert type so it will be sent back to the remote peer and so make it easier for them to fix it.
Modification:
Correctly set the alert and not always just use a general alert.
Result:
It's easier for the remote peer to fix the problems.