OpenSslSession#initPeerCerts creates too long almost empty arrays. #5967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
requested changes
Nov 2, 2016
| } | ||
| } | ||
|
|
||
| private boolean isEmpty(Object[] arr) { |
There was a problem hiding this comment.
@ichaki5748 can you make this method static
| return arr == null || arr.length == 0; | ||
| } | ||
|
|
||
| private boolean isEmpty(byte[] cert) { |
|
@ichaki5748 please do the requested changes and squash. I will cherry-pick after it. |
Motivation: netty#5945 Modifications: Refactored initialization of arrays. Fixed arrays length Result: Cert arrays have proper length. Testing added
netkins
reviewed
Nov 3, 2016
| @@ -1308,6 +1310,14 @@ private void checkEngineClosed(SSLException cause) throws SSLException { | |||
| return pendingStatus > 0 ? NEED_WRAP : NEED_UNWRAP; | |||
| } | |||
|
|
|||
| private static boolean isEmpty(Object[] arr) { | |||
There was a problem hiding this comment.
Consider using varargs for methods or constructors which take an array the last parameter. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#5945
Modifications:
Refactored initialization of arrays. Fixed arrays length
Result:
Cert arrays have proper length. Testing added