prev should be set to null when setting cursor to head in scavengeSome
#6180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@normanmaurer PTAL |
|
@zsxwing awesome! Can you please sign the ICLA and update the community message : http://netty.io/s/icla Let me know once done |
|
Already signed it. |
|
Updated the commit message. |
Motivation: `scavengeSome()` has a corner case: when setting `cursor` to `head`, `this.prev` may point to the tail of the `WeakOrderQueue` linked list. Then it's possible that the following while loop will link the tail to the head, and cause endless loop. I made a reproducer in zsxwing@36522e7 . The unit test will just run forever. Unfortunately, I cannot change it to a unit test because it needs to add some codes to `scavengeSome` to control the execution flow. Modification: Set `prev` to null when setting `cursor` to `head` in `scavengeSome` Result: Fixes #6153.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
prevto null when settingcursortoheadinscavengeSometo fix #6153.Motivation:
scavengeSome()has a corner case: when settingcursortohead,this.prevmay point to the tail of theWeakOrderQueuelinked list. Then it's possible that the following while loop will link the tail to the head, and cause endless loop.I made a reproducer in zsxwing@36522e7 . The unit test will just run forever. Unfortunately, I cannot change it to a unit test because it needs to add some codes to
scavengeSometo control the execution flow.Modification:
Set
prevto null when settingcursortoheadinscavengeSome.Result:
Fixes #6153.