Expose HTTP/2 HpackDecoder #6589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: gRPC (and potentially other libraries) has an optimized header processor that requires direct access to the HpackDecoder. Modifications: Make the HpackDecoder and its constructors public. Result: Fixes netty#6579
| @@ -49,7 +49,7 @@ | |||
| import static io.netty.util.internal.ObjectUtil.checkPositive; | |||
| import static io.netty.util.internal.ThrowableUtil.unknownStackTrace; | |||
|
|
|||
| final class HpackDecoder { | |||
| public class HpackDecoder { | |||
There was a problem hiding this comment.
if we make it public again can we at least make it final ?
There was a problem hiding this comment.
Yup - done. I wasn't sure at first whether gRPC needed to extend but it looks like it doesn't.
Scottmitch
reviewed
Mar 31, 2017
| this(maxHeaderListSize, initialHuffmanDecodeCapacity, DEFAULT_HEADER_TABLE_SIZE); | ||
| } | ||
|
|
||
| /** | ||
| * Exposed Used for testing only! Default values used in the initial settings frame are overriden intentionally | ||
| * for testing but violate the RFC if used outside the scope of testing. | ||
| */ | ||
| HpackDecoder(long maxHeaderListSize, int initialHuffmanDecodeCapacity, int maxHeaderTableSize) { | ||
| public HpackDecoder(long maxHeaderListSize, int initialHuffmanDecodeCapacity, int maxHeaderTableSize) { |
There was a problem hiding this comment.
having this be public can be dangerous as indicated in the comments. Can this stay package private?
|
Lets track followup discussion in #6591 |
Scottmitch
added a commit
to Scottmitch/netty
that referenced
this pull request
Apr 1, 2017
This reverts commit f4c635d.
Scottmitch
added a commit
that referenced
this pull request
Apr 3, 2017
This reverts commit f4c635d.
liuzhengyang
pushed a commit
to liuzhengyang/netty
that referenced
this pull request
Sep 10, 2017
Motivation: gRPC (and potentially other libraries) has an optimized header processor that requires direct access to the HpackDecoder. Modifications: Make the HpackDecoder and its constructors public. Result: Fixes netty#6579
liuzhengyang
pushed a commit
to liuzhengyang/netty
that referenced
this pull request
Sep 10, 2017
This reverts commit f4c635d.
kiril-me
pushed a commit
to kiril-me/netty
that referenced
this pull request
Feb 28, 2018
Motivation: gRPC (and potentially other libraries) has an optimized header processor that requires direct access to the HpackDecoder. Modifications: Make the HpackDecoder and its constructors public. Result: Fixes netty#6579
kiril-me
pushed a commit
to kiril-me/netty
that referenced
this pull request
Feb 28, 2018
This reverts commit f4c635d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
gRPC (and potentially other libraries) has an optimized header processor that requires direct access to the HpackDecoder.
Modifications:
Make the HpackDecoder and its constructors public.
Result:
Fixes #6579