Fix support for shading native libraries which was broken in b818852c… #8091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cchantep please check as well ... thanks! |
normanmaurer
requested review from
mosesn,
ejona86,
bryce-anderson,
Scottmitch and
carl-mastrangelo
Motivation: b818852 broke support for shading the native libraries in netty as it missed to respect the package prefix that is used when shading. Modifications: Correctly respect package prefix for constructor argument and include the used classname when logging that we could not find the constructor. Result: Be able to shade native libraries of netty again.
normanmaurer
force-pushed
the
native_shading_fix
branch
from
3ee47d0
to
bb395ad
Compare
ejona86
approved these changes
Jul 2, 2018
|
I will work on a integration test for this one so we will not break it again |
johnou
reviewed
Jul 3, 2018
| datagramSocketAddrMethodId = (*env)->GetMethodID(env, datagramSocketAddressClass, "<init>", "(Ljava/lang/String;IILio/netty/channel/unix/DatagramSocketAddress;)V"); | ||
|
|
||
| // Respect shading... | ||
| char parameters[1024] = {0}; |
There was a problem hiding this comment.
Wouldn't it be safer to calculate the length instead of using an arbitrary size?
There was a problem hiding this comment.
We could... that said if 1024 is not enough I would be really surprised
There was a problem hiding this comment.
I was thinking in terms of buffer overflow but I assume snprintf guards against that? couldn't we do a simple check that nettyClassName does not exceed 1024 and if it does, throw illegalargumentexception just to be on the safe side?
|
@normanmaurer do you know whether it's published on snapshot repo ? To check with CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…db0ee56ce3cf939e2faa538d519baabd.
Motivation:
b818852 broke support for shading the native libraries in netty as it missed to respect the package prefix that is used when shading.
Modifications:
Correctly respect package prefix for constructor argument and include the used classname when logging that we could not find the constructor.
Result:
Be able to shade native libraries of netty again.