DefaultPromise may throw checked exceptions that are not advertised #8995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
requested review from
Scottmitch,
ejona86,
bryce-anderson,
carl-mastrangelo,
trustin and
vkostyukov
Motivation: We should not throw check exceptions when the user calls sync*() but should better wrap it in a CompletionException to make it easier for people to reason about what happens. Modifications: - Change sync*() to throw CompletionException - Adjust tests - Add some more tests Result: Fixes #8521.
normanmaurer
force-pushed
the
promise_future_exception
branch
from
06344dd
to
fea799c
Compare
|
/cc @njhill @franz1981 |
|
any comments ? |
franz1981
reviewed
Apr 9, 2019
| // expected | ||
| Assert.assertThat(expected.getCause(), CoreMatchers.instanceOf(RejectedExecutionException.class)); |
There was a problem hiding this comment.
Just for readability: import static CoreMatchers.instanceOf
or both is(instanceOf(...
ejona86
approved these changes
Apr 9, 2019
|
@ejona86 yes |
trustin
reviewed
Apr 15, 2019
| @@ -83,12 +83,20 @@ | |||
| /** | |||
| * Waits for this future until it is done, and rethrows the cause of the failure if this future | |||
| * failed. | |||
| * | |||
| * @throws CancellationException if the computation was cancelled | |||
| * @throws {@link java.util.concurrent.CompletionException} if the computation threw an exception. | |||
There was a problem hiding this comment.
Late, but this should be:
@throws CompletionException if the ....
There was a problem hiding this comment.
@trustin you mean removing the "package" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We should not throw check exceptions when the user calls sync*() but should better wrap it in a CompletionException to make it easier for people to reason about what happens.
Modifications:
Result:
Fixes #8521.