Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultPromise may throw checked exceptions that are not advertised #8995

Merged
merged 1 commit into from
Apr 10, 2019
Merged

DefaultPromise may throw checked exceptions that are not advertised #8995

merged 1 commit into from
Apr 10, 2019

Commits on Apr 1, 2019

  1. DefaultPromise may throw checked exceptions that are not advertised 

    Motivation:

We should not throw check exceptions when the user calls sync*() but should better wrap it in a CompletionException to make it easier for people to reason about what happens.

Modifications:

- Change sync*() to throw CompletionException
- Adjust tests
- Add some more tests

Result:

Fixes #8521.
    @normanmaurer
    normanmaurer committed Apr 1, 2019
    Configuration menu
    Copy the full SHA
    fea799c View commit details
    Browse the repository at this point in the history