Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference-counted SslEngines retain a reference to their parent SslContext #9626

Merged
merged 1 commit into from Oct 7, 2019
Merged

Reference-counted SslEngines retain a reference to their parent SslContext #9626

merged 1 commit into from Oct 7, 2019

Commits on Sep 30, 2019

  1. Reference-counted SslEngines retain a reference to their parent SslCo… 

    …ntext

Motivation:
With the Netty ref-counted OpenSSL implementation the parent SslContext
maintains state necessary for the SslEngine's it produces. However, it's
possible for the parent context to be closed and release those resources
before the child engines are finished which causes problems.

Modification:
Spawned ReferenceCountedOpenSslEngine's retain a reference to their
parent ReferenceCountedOpenSslContext.

Result:
The lifetime of the shared data is extended to include the lifetime of
the dependents.
    Bryce Anderson committed Sep 30, 2019
    Copy the full SHA
    10de634 View commit details
    Browse the repository at this point in the history