This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Eeprom filesizes were incorrect, fixed this. (One bit is not a byte) #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I will look at integrating this after I am finished with the current changes. |
networkfusion
suggested changes
Oct 12, 2019
… the correct filesize.
networkfusion
approved these changes
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An ED64 owner was complaining to me about EEPROM filesizes being different (and thus incompatible unless trimmed) from the Everdrive64 firmware.
Turns out the save sizes for those is incorrect so it should fix this.
No idea about SAVE_SIZE_SRAM96 though, i guess this should be compared against the stock firmware. I wonder what games use those ?