Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to validate numeric and Integer in TypeValidator #116

Closed
jiachen1120 opened this issue Feb 8, 2019 · 1 comment
Closed

Fail to validate numeric and Integer in TypeValidator #116

jiachen1120 opened this issue Feb 8, 2019 · 1 comment
Assignees
@jiachen1120
Labels
bug

Comments

@jiachen1120
Copy link
Contributor

jiachen1120 commented Feb 8, 2019 •
edited
Loading

In typeValidator

  1. "+1" will not be recognized as an Integer or Numeric
  2. "All decimals cannot be recognized as numeric
  3. No check for the case "0.0.1"
@jiachen1120 jiachen1120 added the bug label Feb 8, 2019
@jiachen1120 jiachen1120 self-assigned this Feb 8, 2019
@jiachen1120 jiachen1120 changed the title Tiny bug in TypeValidator, lack corner cases in isNumeric() and isInteger() Fail to validate numeric and Integer in TypeValidator Feb 8, 2019
jiachen1120 added a commit that referenced this issue Feb 8, 2019
@jiachen1120
Fix #116 fail to validate numeric and integer in TypeValidator
2147f0a
@jiachen1120 jiachen1120 mentioned this issue Feb 8, 2019
Merged
@stevehu
Copy link
Contributor

stevehu commented Feb 9, 2019

Fail to validate numeric and Integer in TypeValidator

@kosty kosty mentioned this issue Jul 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiachen1120 jiachen1120

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevehu @jiachen1120