Fix/#160 max value float #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value -added test cases
…he compare node is integer type, otherwise means one of schema or compare node is with decimal, so convert it to BigDecimal to do the compare. -change some edge test cases, due to the way of measuring is changed, some edge scenarios don't apply anymore.
-change logback-test from debug to error level due to it may affect performance test
…nto fix/#160-max-value-float
…. the time consuming diff is very small after the change using BigDecimal
…ilar logic to MaximumValidator -added test cases
DSchrupert
reviewed
Jun 13, 2019
DSchrupert
approved these changes
Jun 13, 2019
stevehu
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: #160
did a performance test, it seems no big performance impact use BigDecimal to do the comparison, to use BigDecimal comparison will reduce a lot of defects.
tested with comparing with "1E39", "-1000" 200000 times after change. The average time is
2312ms
tested with comparing with "1000.1", "1000" 200000 times before change. The average time is 2326.8ms