Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy when getting oauth key should not be enabled when the value is empty #877

Closed
BalloonWen opened this issue Dec 21, 2020 · 1 comment · Fixed by #878
Closed

proxy when getting oauth key should not be enabled when the value is empty #877

BalloonWen opened this issue Dec 21, 2020 · 1 comment · Fixed by #878
Assignees
@BalloonWen

Comments

@BalloonWen
Copy link
Contributor

currently in OauthHelper, it will check proxyHost is null or not, but when proxyHost is an empty value, it should also be disabled.
@BalloonWen BalloonWen self-assigned this Dec 21, 2020
BalloonWen added a commit that referenced this issue Dec 21, 2020
@BalloonWen
issue #877
d931a95 
- now the client won't use proxy even the proxyHost is empty
@BalloonWen BalloonWen linked a pull request Dec 22, 2020 that will close this issue
issue #877 Do not use ProxyHost when the value is NULL or Empty #878
Merged
stevehu pushed a commit that referenced this issue Dec 22, 2020
@BalloonWen
issue #877 (#878)
775b362 
- now the client won't use proxy even the proxyHost is empty
@stevehu
Copy link
Contributor

stevehu commented Dec 22, 2020

proxy when getting oauth key should not be enabled when the value is empty light-4j master

younggwon1 pushed a commit to younggwon1/light-4j that referenced this issue Feb 10, 2024
@BalloonWen
issue networknt#877 (networknt#878)
b937ead 
- now the client won't use proxy even the proxyHost is empty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BalloonWen BalloonWen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issue #877 Do not use ProxyHost when the value is NULL or Empty networknt/light-4j
2 participants
@stevehu @BalloonWen