Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: ConsulRegistry keeps the first service url discovered in cache #633

Merged

Conversation

jsu216
Copy link
Contributor

@jsu216 jsu216 commented Dec 19, 2019

Fix the issue

@stevehu stevehu added 1.6.x Merge to 1.6.x Branch 2.0.x Merge to 2.0.x Branch labels Dec 20, 2019
@jsu216 jsu216 force-pushed the ConsulRegistry-keeps-the-first-service-url-discovered-in-cache branch from c52296b to 93dab8d Compare December 20, 2019 16:04
@jsu216
Copy link
Contributor Author

jsu216 commented Dec 20, 2019

@stevehu I move the code change from CommandFailbackRegistry to ConsulRegistry to avoid any possible unexpected change to ZooKeeperRegistry.

@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #633 into 1.6.x will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##              1.6.x     #633      +/-   ##
============================================
- Coverage     50.42%   50.41%   -0.01%     
- Complexity     1912     1913       +1     
============================================
  Files           259      259              
  Lines         11564    11570       +6     
  Branches       1634     1634              
============================================
+ Hits           5831     5833       +2     
- Misses         5046     5051       +5     
+ Partials        687      686       -1
Impacted Files Coverage Δ Complexity Δ
...istry/support/command/CommandFailbackRegistry.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...main/java/com/networknt/consul/ConsulRegistry.java 51.23% <0%> (-1.98%) 21 <0> (ø)
.../src/main/java/com/networknt/utility/HashUtil.java 63.33% <0%> (+3.33%) 11% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 245610b...93dab8d. Read the comment docs.

@stevehu stevehu merged commit 39d4d83 into 1.6.x Dec 20, 2019
@stevehu stevehu deleted the ConsulRegistry-keeps-the-first-service-url-discovered-in-cache branch December 20, 2019 20:32
younggwon1 pushed a commit to younggwon1/light-4j that referenced this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.6.x Merge to 1.6.x Branch 2.0.x Merge to 2.0.x Branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants