This repository has been archived by the owner on Oct 29, 2021. It is now read-only.
Simplify SDK #40
Merged
Simplify SDK #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. It will fail of course until we merge the main SDK PR in the nsm repo |
nickolaev
reviewed
Sep 11, 2019
Simplify SDK Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
nickolaev
reviewed
Sep 12, 2019
|
|
||
| compositeEndpoints = append(compositeEndpoints, endpoint.NewConnectionEndpoint(configuration)) | ||
|
|
||
| compositeEndpoints = append(compositeEndpoints, NewUniversalCNFEndpoint(backend, e)) |
There was a problem hiding this comment.
Hmm, is this still appending?
There was a problem hiding this comment.
Not sure I've understand comment.
Signed-off-by: Andrey Sobolev <haiodo@gmail.com>
nickolaev
approved these changes
Sep 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify SDK
Fixes related to networkservicemesh/networkservicemesh#1524
Signed-off-by: Andrey Sobolev haiodo@gmail.com