refactor: Rework OPA policies with go 'embed' #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denis-tingaikin
force-pushed
the
refactor-opa-to-use-embed
branch
from
aa97513
to
8dc8249
Compare
Bolodya1997
reviewed
Jul 14, 2021
Bolodya1997
reviewed
Jul 14, 2021
denis-tingaikin
force-pushed
the
refactor-opa-to-use-embed
branch
from
8dc8249
to
515ef43
Compare
Bolodya1997
reviewed
Jul 20, 2021
| @@ -103,16 +103,16 @@ func NewServer(ctx context.Context, tokenGenerator token.GeneratorFunc, options | |||
| rv.NetworkServiceServer = chain.NewNamedNetworkServiceServer( | |||
| opts.name, | |||
| append([]networkservice.NetworkServiceServer{ | |||
| serialize.NewServer(), | |||
There was a problem hiding this comment.
serialize cannot stand before updatepath - in such case all Request/Close events generated from refresh/timeout/heal will race with Request/Close coming from previous hop, because they will have different Connection.Id.
There was a problem hiding this comment.
It seems as a problem with serialize . But ok, I'll fix sequence because @edwarnicke planning to replace serialize to begin.
There was a problem hiding this comment.
@Bolodya1997 Do you have an idea why all tests working fine when serialize is first in the chain? Did we miss scenario coverage tests?
There was a problem hiding this comment.
CI for chain when serialize is first https://github.com/networkservicemesh/sdk/actions/runs/1040411831
There was a problem hiding this comment.
We don't have sandbox tests for timeout/refresh overlapping with Close/Request coming from the Client - it is pretty hard to guarantee such case without using clock in sandbox.
Bolodya1997
reviewed
Aug 3, 2021
denis-tingaikin
force-pushed
the
refactor-opa-to-use-embed
branch
2 times, most recently
from
3d9c610
to
86e542c
Compare
Bolodya1997
approved these changes
Aug 9, 2021
Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com>
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
refactor-opa-to-use-embed
branch
from
86e542c
to
919f3b9
Compare
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Aug 19, 2021
…k@main PR link: networkservicemesh/sdk#1018 Commit: 9c4ad0c Author: Denis Tingaikin Date: 2021-08-19 16:52:56 +0300 Message: - refactor: Rework OPA policies with go 'embed' (#1018) * rework OPA policies with go embed Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * move tokens adding from updatepath to upatetoken Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Aug 19, 2021
…k@main PR link: networkservicemesh/sdk#1018 Commit: 9c4ad0c Author: Denis Tingaikin Date: 2021-08-19 16:52:56 +0300 Message: - refactor: Rework OPA policies with go 'embed' (#1018) * rework OPA policies with go embed Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * move tokens adding from updatepath to upatetoken Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Aug 19, 2021
…k@main PR link: networkservicemesh/sdk#1018 Commit: 9c4ad0c Author: Denis Tingaikin Date: 2021-08-19 16:52:56 +0300 Message: - refactor: Rework OPA policies with go 'embed' (#1018) * rework OPA policies with go embed Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * move tokens adding from updatepath to upatetoken Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-icmp-responder
that referenced
this pull request
Aug 19, 2021
…k@main PR link: networkservicemesh/sdk#1018 Commit: 9c4ad0c Author: Denis Tingaikin Date: 2021-08-19 16:52:56 +0300 Message: - refactor: Rework OPA policies with go 'embed' (#1018) * rework OPA policies with go embed Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * move tokens adding from updatepath to upatetoken Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Aug 19, 2021
…k@main PR link: networkservicemesh/sdk#1018 Commit: 9c4ad0c Author: Denis Tingaikin Date: 2021-08-19 16:52:56 +0300 Message: - refactor: Rework OPA policies with go 'embed' (#1018) * rework OPA policies with go embed Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * move tokens adding from updatepath to upatetoken Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Aug 19, 2021
…k@main PR link: networkservicemesh/sdk#1018 Commit: 9c4ad0c Author: Denis Tingaikin Date: 2021-08-19 16:52:56 +0300 Message: - refactor: Rework OPA policies with go 'embed' (#1018) * rework OPA policies with go embed Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * move tokens adding from updatepath to upatetoken Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Aug 19, 2021
…k@main PR link: networkservicemesh/sdk#1018 Commit: 9c4ad0c Author: Denis Tingaikin Date: 2021-08-19 16:52:56 +0300 Message: - refactor: Rework OPA policies with go 'embed' (#1018) * rework OPA policies with go embed Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * move tokens adding from updatepath to upatetoken Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Aug 19, 2021
…k@main PR link: networkservicemesh/sdk#1018 Commit: 9c4ad0c Author: Denis Tingaikin Date: 2021-08-19 16:52:56 +0300 Message: - refactor: Rework OPA policies with go 'embed' (#1018) * rework OPA policies with go embed Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * move tokens adding from updatepath to upatetoken Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Aug 19, 2021
…k@main PR link: networkservicemesh/sdk#1018 Commit: 9c4ad0c Author: Denis Tingaikin Date: 2021-08-19 16:52:56 +0300 Message: - refactor: Rework OPA policies with go 'embed' (#1018) * rework OPA policies with go embed Signed-off-by: denis-tingajkin <denis.tingajkin@xored.com> * move tokens adding from updatepath to upatetoken Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * fix linter issue Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * apply review comments Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 19, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: denis-tingajkin denis.tingajkin@xored.com
Description
Motivation
updatepath. Now updatepath is just updating path.How Has This Been Tested?
Types of changes