Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qfix] Fix kernel client #1024

Merged
merged 1 commit into from
Jul 16, 2021
Merged

[qfix] Fix kernel client #1024

merged 1 commit into from
Jul 16, 2021

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Jul 16, 2021 •
edited
Loading

Description

Fixes kernelMechanismClient to:

  1. use kernel.Mechanism instead of raw parameters
  2. set valid net NS URL on every request
  3. set valid kernel interface name on mechanism update

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Fix kernel client
01e73b3 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997 Bolodya1997 self-assigned this Jul 16, 2021
@Bolodya1997 Bolodya1997 requested review from denis-tingaikin and glazychev-art and removed request for denis-tingaikin July 16, 2021 04:57
@denis-tingaikin denis-tingaikin merged commit 0197a16 into networkservicemesh:main Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@glazychev-art glazychev-art glazychev-art approved these changes

Assignees

@glazychev-art glazychev-art

@Bolodya1997 Bolodya1997

@denis-tingaikin denis-tingaikin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bolodya1997 @glazychev-art @denis-tingaikin