Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sdk-vpp#314] Support empty chains #1044

Merged
merged 1 commit into from
Aug 13, 2021
Merged

[sdk-vpp#314] Support empty chains #1044

merged 1 commit into from
Aug 13, 2021

Conversation

Bolodya1997
Copy link

@Bolodya1997 Bolodya1997 commented Jul 29, 2021 •
edited
Loading

Description

Add support for empty subchains (networkservice, NS registry, NSE registry):

var serversA, serversB, serversC []networkservice.Server
...
server := chain.NewServer(
    chain.NewServer(serversA...), // <-- now can be empty
    chain.NewServer(serversB...), // <-- now can be empty
    chain.NewServer(serversC...), // <-- now can be empty
)

Issue link

Needed for networkservicemesh/sdk-vpp#314.

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@Bolodya1997 Bolodya1997 mentioned this pull request Jul 30, 2021
Closed
9 tasks
denis-tingaikin
denis-tingaikin requested changes Aug 13, 2021
View reviewed changes
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide an example on how you plan to use this chain element in context sdk-vpp#314? Thanks.

Support empty chains
7fa5747 
Signed-off-by: Vladimir Popov <vladimir.popov@xored.com>
@Bolodya1997
Copy link
Author

@denis-tingaikin
Removed refactoring from this PR.

@denis-tingaikin denis-tingaikin merged commit 1fce3fe into networkservicemesh:main Aug 13, 2021
nsmbot pushed a commit to networkservicemesh/cmd-nse-icmp-responder that referenced this pull request Aug 13, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4bbf9e9 
…k@main

PR link: networkservicemesh/sdk#1044

Commit: 1fce3fe
Author: Vladimir Popov
Date: 2021-08-13 17:56:11 +0700
Message:
  - Support empty chains (#1044)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Aug 13, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d88d09e 
…k@main

PR link: networkservicemesh/sdk#1044

Commit: 1fce3fe
Author: Vladimir Popov
Date: 2021-08-13 17:56:11 +0700
Message:
  - Support empty chains (#1044)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 13, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
64fc036 
…k@main

PR link: networkservicemesh/sdk#1044

Commit: 1fce3fe
Author: Vladimir Popov
Date: 2021-08-13 17:56:11 +0700
Message:
  - Support empty chains (#1044)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Aug 13, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
b8c0888 
…k@main

PR link: networkservicemesh/sdk#1044

Commit: 1fce3fe
Author: Vladimir Popov
Date: 2021-08-13 17:56:11 +0700
Message:
  - Support empty chains (#1044)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Aug 13, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
324bec5 
…k@main

PR link: networkservicemesh/sdk#1044

Commit: 1fce3fe
Author: Vladimir Popov
Date: 2021-08-13 17:56:11 +0700
Message:
  - Support empty chains (#1044)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Aug 13, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
918a99e 
…k@main

PR link: networkservicemesh/sdk#1044

Commit: 1fce3fe
Author: Vladimir Popov
Date: 2021-08-13 17:56:11 +0700
Message:
  - Support empty chains (#1044)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Aug 13, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
025b53e 
…k@main

PR link: networkservicemesh/sdk#1044

Commit: 1fce3fe
Author: Vladimir Popov
Date: 2021-08-13 17:56:11 +0700
Message:
  - Support empty chains (#1044)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Aug 13, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0e02508 
…k@main

PR link: networkservicemesh/sdk#1044

Commit: 1fce3fe
Author: Vladimir Popov
Date: 2021-08-13 17:56:11 +0700
Message:
  - Support empty chains (#1044)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Aug 13, 2021
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c9b17c0 
…k@main

PR link: networkservicemesh/sdk#1044

Commit: 1fce3fe
Author: Vladimir Popov
Date: 2021-08-13 17:56:11 +0700
Message:
  - Support empty chains (#1044)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 13, 2021
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 13, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

@d-uzlov d-uzlov d-uzlov approved these changes

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

@glazychev-art glazychev-art Awaiting requested review from glazychev-art

@Mixaster995 Mixaster995 Awaiting requested review from Mixaster995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bolodya1997 @d-uzlov @denis-tingaikin