-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vlan multiplexing] add vlan tag for vlan supported kernel mechanism #1088
Conversation
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
/cc @JanScheurich |
Does that mean the VLAN-multiplexing will only work with local kernel mechanism? That would exclude VLAN multiplexing on SRIOV vfio devices in NSE pods. For Mellanox SmartVFs it's OK as they are kernel mechanisms as well as DPDK devices. |
@pperiyasamy |
Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech>
@pperiyasamy Would it possibly make more sense to have a separate 'vlan' chain element that handles these details? (similar to how vni is handled) This would give nice modularity, and allow easy use of vlan multiplexing across different mechanisms. |
@edwarnicke @JanScheurich where do you want 'vlan' chain element to be placed ? currently only kernel mechanism has vlan parameter support, so can we place it under sdk/pkg/networkservice/common/mechanisms/kernel/vlan for now ? |
@pperiyasamy Sounds about right :) |
51d9c83
to
c41882c
Compare
done. please review it now. |
@pperiyasamy This looks good. @JanScheurich A brief comment here on 'working with other non kernel mechanisms'. As written, the implementation @pperiyasamy has provided only works for kernel mechanism... but it has the right architectural whitespace to be easily extended to any Vlan supporting mechanism. I'll talk through how briefly, and you can all decide when you'd like to make those extensions :) Right now the constants 'SupportsVLAN' and 'VLAN' are only defined in api/networkservice/mechanisms/kernel/constants.go. As you can see just above there, we've in the past defined some constants by reference to 'common' because those constants get used in multiple mechanisms. vlan multiplexing is seen as a cross-cutting concern... you could treat it as such by introducing Thoughts? |
…k@main PR link: networkservicemesh/sdk#1088 Commit: e550639 Author: peri Date: 2021-09-29 15:14:41 +0200 Message: - [vlan multiplexing] add vlan tag for vlan supported kernel mechanism (#1088) * add vlan tag for vlan supported kernel mechanism Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * use options closure to set vlan id range Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "use options closure to set vlan id range" This reverts commit cf8d38b6312c52582cc8c9e6e78125453f095779. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "add vlan tag for vlan supported kernel mechanism" This reverts commit 1d6415f19687b518434114f14bdf22330b97c21a. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * add vlan server chain element Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1088 Commit: e550639 Author: peri Date: 2021-09-29 15:14:41 +0200 Message: - [vlan multiplexing] add vlan tag for vlan supported kernel mechanism (#1088) * add vlan tag for vlan supported kernel mechanism Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * use options closure to set vlan id range Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "use options closure to set vlan id range" This reverts commit cf8d38b6312c52582cc8c9e6e78125453f095779. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "add vlan tag for vlan supported kernel mechanism" This reverts commit 1d6415f19687b518434114f14bdf22330b97c21a. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * add vlan server chain element Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1088 Commit: e550639 Author: peri Date: 2021-09-29 15:14:41 +0200 Message: - [vlan multiplexing] add vlan tag for vlan supported kernel mechanism (#1088) * add vlan tag for vlan supported kernel mechanism Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * use options closure to set vlan id range Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "use options closure to set vlan id range" This reverts commit cf8d38b6312c52582cc8c9e6e78125453f095779. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "add vlan tag for vlan supported kernel mechanism" This reverts commit 1d6415f19687b518434114f14bdf22330b97c21a. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * add vlan server chain element Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1088 Commit: e550639 Author: peri Date: 2021-09-29 15:14:41 +0200 Message: - [vlan multiplexing] add vlan tag for vlan supported kernel mechanism (#1088) * add vlan tag for vlan supported kernel mechanism Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * use options closure to set vlan id range Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "use options closure to set vlan id range" This reverts commit cf8d38b6312c52582cc8c9e6e78125453f095779. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "add vlan tag for vlan supported kernel mechanism" This reverts commit 1d6415f19687b518434114f14bdf22330b97c21a. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * add vlan server chain element Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1088 Commit: e550639 Author: peri Date: 2021-09-29 15:14:41 +0200 Message: - [vlan multiplexing] add vlan tag for vlan supported kernel mechanism (#1088) * add vlan tag for vlan supported kernel mechanism Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * use options closure to set vlan id range Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "use options closure to set vlan id range" This reverts commit cf8d38b6312c52582cc8c9e6e78125453f095779. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "add vlan tag for vlan supported kernel mechanism" This reverts commit 1d6415f19687b518434114f14bdf22330b97c21a. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * add vlan server chain element Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1088 Commit: e550639 Author: peri Date: 2021-09-29 15:14:41 +0200 Message: - [vlan multiplexing] add vlan tag for vlan supported kernel mechanism (#1088) * add vlan tag for vlan supported kernel mechanism Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * use options closure to set vlan id range Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "use options closure to set vlan id range" This reverts commit cf8d38b6312c52582cc8c9e6e78125453f095779. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "add vlan tag for vlan supported kernel mechanism" This reverts commit 1d6415f19687b518434114f14bdf22330b97c21a. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * add vlan server chain element Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1088 Commit: e550639 Author: peri Date: 2021-09-29 15:14:41 +0200 Message: - [vlan multiplexing] add vlan tag for vlan supported kernel mechanism (#1088) * add vlan tag for vlan supported kernel mechanism Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * use options closure to set vlan id range Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "use options closure to set vlan id range" This reverts commit cf8d38b6312c52582cc8c9e6e78125453f095779. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "add vlan tag for vlan supported kernel mechanism" This reverts commit 1d6415f19687b518434114f14bdf22330b97c21a. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * add vlan server chain element Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1088 Commit: e550639 Author: peri Date: 2021-09-29 15:14:41 +0200 Message: - [vlan multiplexing] add vlan tag for vlan supported kernel mechanism (#1088) * add vlan tag for vlan supported kernel mechanism Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * use options closure to set vlan id range Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "use options closure to set vlan id range" This reverts commit cf8d38b6312c52582cc8c9e6e78125453f095779. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * Revert "add vlan tag for vlan supported kernel mechanism" This reverts commit 1d6415f19687b518434114f14bdf22330b97c21a. Signed-off-by: Periyasamy Palanisamy <periyasamy.palanisamy@est.tech> * add vlan server chain element Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Makes sense. The current implementation in the kernel mechanism is sufficient for our OVS forwarder + SmartVF use case. We can leave the generalization to a future contributor. |
This is what I expected :) That's why I merged this PR and just left my comment in case I misread the situation :) |
The good news is its actually pretty each and non-impactful to generalize from @pperiyasamy 's implementation here :) |
@Bolodya1997 @edwarnicke @JanScheurich Thanks all for your inputs ! |
Signed-off-by: Periyasamy Palanisamy periyasamy.palanisamy@est.tech
Description
Issue link
How Has This Been Tested?
Types of changes