Made group logger creation public #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
pkg/tools/log/grouplogger.go
Outdated
| @@ -23,7 +23,8 @@ type groupLogger struct { | |||
| loggers []Logger | |||
| } | |||
|
|
|||
| func newGroup(s ...Logger) Logger { | |||
| // New creates grouped logger from all provided loggers | |||
| func New(s ...Logger) Logger { | |||
There was a problem hiding this comment.
Suggested change
| func New(s ...Logger) Logger { | |
| func Combine(s ...Logger) Logger { |
Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com>
denis-tingaikin
approved these changes
Nov 24, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Nov 24, 2021
…k@main PR link: networkservicemesh/sdk#1171 Commit: 658a1ca Author: Авраменко Михаил Date: 2021-11-24 14:11:54 +0700 Message: - Made group logger creation public (#1171) * made group logger creation public Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * renamed grouping method Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Nov 24, 2021
…k@main PR link: networkservicemesh/sdk#1171 Commit: 658a1ca Author: Авраменко Михаил Date: 2021-11-24 14:11:54 +0700 Message: - Made group logger creation public (#1171) * made group logger creation public Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * renamed grouping method Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Nov 24, 2021
…k@main PR link: networkservicemesh/sdk#1171 Commit: 658a1ca Author: Авраменко Михаил Date: 2021-11-24 14:11:54 +0700 Message: - Made group logger creation public (#1171) * made group logger creation public Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * renamed grouping method Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Nov 24, 2021
…k@main PR link: networkservicemesh/sdk#1171 Commit: 658a1ca Author: Авраменко Михаил Date: 2021-11-24 14:11:54 +0700 Message: - Made group logger creation public (#1171) * made group logger creation public Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * renamed grouping method Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Nov 24, 2021
…k@main PR link: networkservicemesh/sdk#1171 Commit: 658a1ca Author: Авраменко Михаил Date: 2021-11-24 14:11:54 +0700 Message: - Made group logger creation public (#1171) * made group logger creation public Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * renamed grouping method Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Nov 24, 2021
…k@main PR link: networkservicemesh/sdk#1171 Commit: 658a1ca Author: Авраменко Михаил Date: 2021-11-24 14:11:54 +0700 Message: - Made group logger creation public (#1171) * made group logger creation public Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * renamed grouping method Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Nov 24, 2021
…k@main PR link: networkservicemesh/sdk#1171 Commit: 658a1ca Author: Авраменко Михаил Date: 2021-11-24 14:11:54 +0700 Message: - Made group logger creation public (#1171) * made group logger creation public Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * renamed grouping method Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Nov 24, 2021
…k@main PR link: networkservicemesh/sdk#1171 Commit: 658a1ca Author: Авраменко Михаил Date: 2021-11-24 14:11:54 +0700 Message: - Made group logger creation public (#1171) * made group logger creation public Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * renamed grouping method Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Nov 24, 2021
…k@main PR link: networkservicemesh/sdk#1171 Commit: 658a1ca Author: Авраменко Михаил Date: 2021-11-24 14:11:54 +0700 Message: - Made group logger creation public (#1171) * made group logger creation public Signed-off-by: Mikhail Avramenko <avramenkomihail15@gmail.com> * renamed grouping method Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for networkservicemesh/cmd-nsmgr#422