Add logs to healClient #1195
Merged
Add logs to healClient #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,7 +63,7 @@ func (h *healClient) Request(ctx context.Context, request *networkservice.Networ | |||
| } | |||
| cc, ccLoaded := clientconn.Load(ctx) | |||
| if ccLoaded { | |||
| cancelEventLoop, eventLoopErr := newEventLoop(h.chainCtx, begin.FromContext(ctx), cc, conn, h.livelinessCheck) | |||
| cancelEventLoop, eventLoopErr := newEventLoop(h.chainCtx, begin.FromContext(ctx), cc, conn, h.livelinessCheck, log.FromContext(ctx)) | |||
There was a problem hiding this comment.
Suggested change
| cancelEventLoop, eventLoopErr := newEventLoop(h.chainCtx, begin.FromContext(ctx), cc, conn, h.livelinessCheck, log.FromContext(ctx)) | |
| cancelEventLoop, eventLoopErr := newEventLoop(extend.WithValuesFromContext(h.chainCtx, ctx), cc, conn, h.livelinessCheck) |
Then you can get logger and begin from the ctx:
b := begin.FromContext(ctx)
logger := log.FromContext(ctx).WithField(...)
There was a problem hiding this comment.
thank you, fixed
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
heal_log
branch
from
cf37cfe
to
0aa151e
Compare
denis-tingaikin
approved these changes
Dec 9, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Dec 9, 2021
…k@main PR link: networkservicemesh/sdk#1195 Commit: 0b0a87a Author: Artem Glazychev Date: 2021-12-09 21:11:08 +0700 Message: - Add logs to healClient (#1195) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Dec 9, 2021
…k@main PR link: networkservicemesh/sdk#1195 Commit: 0b0a87a Author: Artem Glazychev Date: 2021-12-09 21:11:08 +0700 Message: - Add logs to healClient (#1195) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Dec 9, 2021
…k@main PR link: networkservicemesh/sdk#1195 Commit: 0b0a87a Author: Artem Glazychev Date: 2021-12-09 21:11:08 +0700 Message: - Add logs to healClient (#1195) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Dec 9, 2021
…k@main PR link: networkservicemesh/sdk#1195 Commit: 0b0a87a Author: Artem Glazychev Date: 2021-12-09 21:11:08 +0700 Message: - Add logs to healClient (#1195) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Dec 9, 2021
…k@main PR link: networkservicemesh/sdk#1195 Commit: 0b0a87a Author: Artem Glazychev Date: 2021-12-09 21:11:08 +0700 Message: - Add logs to healClient (#1195) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Dec 9, 2021
…k@main PR link: networkservicemesh/sdk#1195 Commit: 0b0a87a Author: Artem Glazychev Date: 2021-12-09 21:11:08 +0700 Message: - Add logs to healClient (#1195) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Dec 9, 2021
…k@main PR link: networkservicemesh/sdk#1195 Commit: 0b0a87a Author: Artem Glazychev Date: 2021-12-09 21:11:08 +0700 Message: - Add logs to healClient (#1195) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Dec 9, 2021
…k@main PR link: networkservicemesh/sdk#1195 Commit: 0b0a87a Author: Artem Glazychev Date: 2021-12-09 21:11:08 +0700 Message: - Add logs to healClient (#1195) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Dec 9, 2021
…k@main PR link: networkservicemesh/sdk#1195 Commit: 0b0a87a Author: Artem Glazychev Date: 2021-12-09 21:11:08 +0700 Message: - Add logs to healClient (#1195) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com
Description
Added logs to healClient to to localize this problem:
networkservicemesh/integration-k8s-packet#185
Issue link
How Has This Been Tested?
Types of changes