Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qfix: Localbypass is not working properly in integration-tests scenarious #1219

Merged
merged 1 commit into from
Jan 27, 2022
Merged

qfix: Localbypass is not working properly in integration-tests scenarious #1219

merged 1 commit into from
Jan 27, 2022

Conversation

denis-tingaikin
Copy link
Member

Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com

Description

The current localbypass order is not correct.

Actual:

Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(18.1)                    network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":"tcp://10.244.1.20:5001","expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(23)                       ⎆ api/pkg/api/registry/networkServiceEndpointRegistryFindClient.Recv()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(17)                 ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(17.1)                   network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":"unix:///proc/1/fd/11","expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(16)                ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(16.1)                  network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":"inode://1048806/7095217","expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(15)               ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(15.1)                 network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":"inode://1048806/7095217","expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(14)              ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(14.1)                network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":"inode://1048806/7095217","expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(13)             ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(13.1)               network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":"inode://1048806/7095217","expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(12)            ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(12.1)              network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":"inode://1048806/7095217","expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}

Expected

Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(18.1)                    network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":"tcp://10.244.1.20:5001","expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(23)                       ⎆ api/pkg/api/registry/networkServiceEndpointRegistryFindClient.Recv()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(17)                 ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(17.1)                   network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":"unix:///proc/1/fd/11","expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(16)                ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(16.1)                  network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":**"unix:///proc/1/fd/11"**,"expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(15)               ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(15.1)                 network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":**"unix:///proc/1/fd/11"**,"expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(14)              ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(14.1)                network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":**"unix:///proc/1/fd/11"**,"expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(13)             ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(13.1)               network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},**"unix:///proc/1/fd/11"**,"expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(12)            ⎆ sdk/pkg/registry/core/streamcontext/networkServiceEndpointRegistryFindServer.Send()
Jan 27 17:56:54.379�[37m [TRAC] [type:registry] �[0m(12.1)              network service endpoint={"name":"forwarder-vpp-pt2q7","network_service_names":["forwarder"],"network_service_labels":{"forwarder":{"labels":{"nodeName":"kind-worker","p2p":"true"}}},"url":**"unix:///proc/1/fd/11"**,"expiration_time":{"seconds":1643306254,"nanos":137086614},"initial_registration_time":{"seconds":1643306194,"nanos":143158306}}

Issue link

Closes networkservicemesh/integration-k8s-kind#565

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
fix for integration tests
28a25b4 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit 6d5254a into networkservicemesh:main Jan 27, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0d7052c 
…k@main

PR link: networkservicemesh/sdk#1219

Commit: 6d5254a
Author: Denis Tingaikin
Date: 2022-01-27 22:32:11 +0300
Message:
  - fix for integration tests (#1219)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
27e3986 
…k@main

PR link: networkservicemesh/sdk#1219

Commit: 6d5254a
Author: Denis Tingaikin
Date: 2022-01-27 22:32:11 +0300
Message:
  - fix for integration tests (#1219)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ff0a635 
…k@main

PR link: networkservicemesh/sdk#1219

Commit: 6d5254a
Author: Denis Tingaikin
Date: 2022-01-27 22:32:11 +0300
Message:
  - fix for integration tests (#1219)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
dc9c5d1 
…k@main

PR link: networkservicemesh/sdk#1219

Commit: 6d5254a
Author: Denis Tingaikin
Date: 2022-01-27 22:32:11 +0300
Message:
  - fix for integration tests (#1219)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f7889fa 
…k@main

PR link: networkservicemesh/sdk#1219

Commit: 6d5254a
Author: Denis Tingaikin
Date: 2022-01-27 22:32:11 +0300
Message:
  - fix for integration tests (#1219)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a904be3 
…k@main

PR link: networkservicemesh/sdk#1219

Commit: 6d5254a
Author: Denis Tingaikin
Date: 2022-01-27 22:32:11 +0300
Message:
  - fix for integration tests (#1219)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6f17850 
…k@main

PR link: networkservicemesh/sdk#1219

Commit: 6d5254a
Author: Denis Tingaikin
Date: 2022-01-27 22:32:11 +0300
Message:
  - fix for integration tests (#1219)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
4c43bcb 
…k@main

PR link: networkservicemesh/sdk#1219

Commit: 6d5254a
Author: Denis Tingaikin
Date: 2022-01-27 22:32:11 +0300
Message:
  - fix for integration tests (#1219)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9fb4569 
…k@main

PR link: networkservicemesh/sdk#1219

Commit: 6d5254a
Author: Denis Tingaikin
Date: 2022-01-27 22:32:11 +0300
Message:
  - fix for integration tests (#1219)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jan 27, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
486a7e5 
…k@main

PR link: networkservicemesh/sdk#1219

Commit: 6d5254a
Author: Denis Tingaikin
Date: 2022-01-27 22:32:11 +0300
Message:
  - fix for integration tests (#1219)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 27, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @edwarnicke