Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nse URL in localbypass if nse was restarted #1225

Merged

Conversation

glazychev-art
Copy link
Contributor

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

If NSE restarted - it it can use the same name but different URL.
localbypass should handle this case.

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit 129dfff into networkservicemesh:main Feb 9, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Feb 9, 2022
…k@main

PR link: networkservicemesh/sdk#1225

Commit: 129dfff
Author: Artem Glazychev
Date: 2022-02-09 16:30:15 +0700
Message:
  - Change nse URL in localbypass if nse was restarted (#1225)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Feb 9, 2022
…k@main

PR link: networkservicemesh/sdk#1225

Commit: 129dfff
Author: Artem Glazychev
Date: 2022-02-09 16:30:15 +0700
Message:
  - Change nse URL in localbypass if nse was restarted (#1225)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 9, 2022
…k@main

PR link: networkservicemesh/sdk#1225

Commit: 129dfff
Author: Artem Glazychev
Date: 2022-02-09 16:30:15 +0700
Message:
  - Change nse URL in localbypass if nse was restarted (#1225)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Feb 9, 2022
…k@main

PR link: networkservicemesh/sdk#1225

Commit: 129dfff
Author: Artem Glazychev
Date: 2022-02-09 16:30:15 +0700
Message:
  - Change nse URL in localbypass if nse was restarted (#1225)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 9, 2022
…k@main

PR link: networkservicemesh/sdk#1225

Commit: 129dfff
Author: Artem Glazychev
Date: 2022-02-09 16:30:15 +0700
Message:
  - Change nse URL in localbypass if nse was restarted (#1225)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 9, 2022
…k@main

PR link: networkservicemesh/sdk#1225

Commit: 129dfff
Author: Artem Glazychev
Date: 2022-02-09 16:30:15 +0700
Message:
  - Change nse URL in localbypass if nse was restarted (#1225)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 9, 2022
…k@main

PR link: networkservicemesh/sdk#1225

Commit: 129dfff
Author: Artem Glazychev
Date: 2022-02-09 16:30:15 +0700
Message:
  - Change nse URL in localbypass if nse was restarted (#1225)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 9, 2022
…k@main

PR link: networkservicemesh/sdk#1225

Commit: 129dfff
Author: Artem Glazychev
Date: 2022-02-09 16:30:15 +0700
Message:
  - Change nse URL in localbypass if nse was restarted (#1225)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 9, 2022
…k@main

PR link: networkservicemesh/sdk#1225

Commit: 129dfff
Author: Artem Glazychev
Date: 2022-02-09 16:30:15 +0700
Message:
  - Change nse URL in localbypass if nse was restarted (#1225)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 9, 2022
…k@main

PR link: networkservicemesh/sdk#1225

Commit: 129dfff
Author: Artem Glazychev
Date: 2022-02-09 16:30:15 +0700
Message:
  - Change nse URL in localbypass if nse was restarted (#1225)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants