Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop resource leaking in client connections on find queries #1228

Merged
merged 2 commits into from
Feb 11, 2022
Merged

fix: stop resource leaking in client connections on find queries #1228

merged 2 commits into from
Feb 11, 2022

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented Feb 11, 2022 •
edited
Loading

Signed-off-by: denis-tingaikin denis.tingajkin@xored.com

Description

Without this patch

refresh count memory kB
1 6000
10 8000
100 22000
500 80000
1000 FAIL

With this patch

refresh count memory kB
1 6000
10 8000
100 9000
500 10000
1000 10000

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
fix memory leaks
90f3ecd 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
fix linter issue
8852ae5 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit 9d5c3f7 into networkservicemesh:main Feb 11, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Feb 11, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a0b60be 
…k@main

PR link: networkservicemesh/sdk#1228

Commit: 9d5c3f7
Author: Denis Tingaikin
Date: 2022-02-11 19:19:56 +0300
Message:
  - fix: stop resource leaking in client connections on find queries (#1228)
* fix memory leaks

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter issue

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Feb 11, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f22425b 
…k@main

PR link: networkservicemesh/sdk#1228

Commit: 9d5c3f7
Author: Denis Tingaikin
Date: 2022-02-11 19:19:56 +0300
Message:
  - fix: stop resource leaking in client connections on find queries (#1228)
* fix memory leaks

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter issue

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Feb 11, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
ef18ac1 
…k@main

PR link: networkservicemesh/sdk#1228

Commit: 9d5c3f7
Author: Denis Tingaikin
Date: 2022-02-11 19:19:56 +0300
Message:
  - fix: stop resource leaking in client connections on find queries (#1228)
* fix memory leaks

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter issue

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Feb 11, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
74131f9 
…k@main

PR link: networkservicemesh/sdk#1228

Commit: 9d5c3f7
Author: Denis Tingaikin
Date: 2022-02-11 19:19:56 +0300
Message:
  - fix: stop resource leaking in client connections on find queries (#1228)
* fix memory leaks

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter issue

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Feb 11, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
2850a75 
…k@main

PR link: networkservicemesh/sdk#1228

Commit: 9d5c3f7
Author: Denis Tingaikin
Date: 2022-02-11 19:19:56 +0300
Message:
  - fix: stop resource leaking in client connections on find queries (#1228)
* fix memory leaks

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter issue

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Feb 11, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1bb7c83 
…k@main

PR link: networkservicemesh/sdk#1228

Commit: 9d5c3f7
Author: Denis Tingaikin
Date: 2022-02-11 19:19:56 +0300
Message:
  - fix: stop resource leaking in client connections on find queries (#1228)
* fix memory leaks

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter issue

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Feb 11, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e10f1c4 
…k@main

PR link: networkservicemesh/sdk#1228

Commit: 9d5c3f7
Author: Denis Tingaikin
Date: 2022-02-11 19:19:56 +0300
Message:
  - fix: stop resource leaking in client connections on find queries (#1228)
* fix memory leaks

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter issue

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Feb 11, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
08b5688 
…k@main

PR link: networkservicemesh/sdk#1228

Commit: 9d5c3f7
Author: Denis Tingaikin
Date: 2022-02-11 19:19:56 +0300
Message:
  - fix: stop resource leaking in client connections on find queries (#1228)
* fix memory leaks

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter issue

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Feb 11, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
abfceeb 
…k@main

PR link: networkservicemesh/sdk#1228

Commit: 9d5c3f7
Author: Denis Tingaikin
Date: 2022-02-11 19:19:56 +0300
Message:
  - fix: stop resource leaking in client connections on find queries (#1228)
* fix memory leaks

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter issue

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Feb 11, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
696b940 
…k@main

PR link: networkservicemesh/sdk#1228

Commit: 9d5c3f7
Author: Denis Tingaikin
Date: 2022-02-11 19:19:56 +0300
Message:
  - fix: stop resource leaking in client connections on find queries (#1228)
* fix memory leaks

Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>

* fix linter issue

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Feb 11, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke Awaiting requested review from edwarnicke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @edwarnicke