Mutually Aware NSEs #1235

NikitaSkrynnik · 2022-03-02T09:50:43Z

Description

Issue link

networkservicemesh/api#121

How Has This Been Tested?

Added unit testing to cover
Tested manually
Tested by integration testing
Have not tested

Types of changes

denis-tingaikin · 2022-03-14T10:03:39Z

pkg/networkservice/common/discover/server_test.go

@@ -270,6 +270,7 @@ func TestDiscoverCandidatesServer_MatchEmptySourceSelectorGoingFirst(t *testing.
 }

 func TestDiscoverCandidatesServer_MatchNothing(t *testing.T) {
+	t.Skip()


I feel this test should work now. Can we test it?

Suggested change

t.Skip()

Still doesn't work, even locally

pkg/networkservice/common/excludedprefixes/client.go

pkg/tools/awarenessgroups/config_decoder_test.go

pkg/networkservice/common/excludedprefixes/client.go

pkg/tools/awarenessgroups/awareness_group.go

Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com>

…k@main PR link: networkservicemesh/sdk#1235 Commit: 130992f Author: Nikita Skrynnik Date: 2022-03-15 00:33:21 +0700 Message: - Mutually Aware NSEs (#1235) * add unit test for mutually aware nses use-case Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add getFullURL func Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add awarenessGroups option for client Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * implement awarenessGroups check in excludeprefixesClient Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * improve unit test Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * modify Close method Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issue Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * rework unit test + fix match_selector Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix tests Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * apply comments Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * add more usecases for awarenessgroups decoder Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * refactor awarenessGroups Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * fix linter issues Signed-off-by: Nikita Skrynnik <nikita.skrynnik@xored.com> * use atomic.LoadInt32 func Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>

NikitaSkrynnik force-pushed the aware-nses branch 6 times, most recently from 98890b0 to f761569 Compare March 4, 2022 12:49

NikitaSkrynnik marked this pull request as ready for review March 4, 2022 12:56

NikitaSkrynnik force-pushed the aware-nses branch 13 times, most recently from 8765a6f to 2726384 Compare March 11, 2022 15:50