Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… #1291

Merged
merged 2 commits into from
May 14, 2022
Merged

fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… #1291

merged 2 commits into from
May 14, 2022

Conversation

denis-tingaikin
Copy link
Member

… file data lose

Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com

Description

I saw when cmd-nsc-init did incorrect restore file that makes data inconsistent.

Seems like on CPU bound POD (cmd-nsc-init is CPU bounded) the goroutine could be stopped before work done.

Logs

/etc # cat resolv.conf
nameserver 127.0.0.1/etc # 
/etc # cat resolv.conf.restore 
/etc # cat resolv.conf.restore 
/etc # cat resolv.conf
/etc # cat resolv.conf.restore 
/etc # cat coredns/Corefile 
. {
        fanout . 172.16.1.2
        log
        reload
        cache {
                denial 0
        }
}. {
        fanout . 172.16.1.2
        log
        reload
        cache {
                denial 0
        }
}/etc # exit

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
remove goroutine that restore resolv.conf file to prevent resolv.conf…
abf7bf0 
… file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@denis-tingaikin
fix linter issues
2bd68e6 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit f0081c8 into networkservicemesh:main May 14, 2022
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a884cb3 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
951e1f5 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9b7733e 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
11b8964 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9991661 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
520e9dd 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
66e38f0 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bcb2023 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
94983aa 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
436a174 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9a8715c 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request May 14, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
37127e7 
…k@main

PR link: networkservicemesh/sdk#1291

Commit: f0081c8
Author: Denis Tingaikin
Date: 2022-05-15 01:11:42 +0300
Message:
  - fix: remove go-routine that restore resolv.conf file to prevent resolv.conf… (#1291)
* remove goroutine that restore resolv.conf file to prevent resolv.conf file data lose

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>

* fix linter issues

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced May 14, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @edwarnicke