Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nscs cant properly restore resolv.conf file on packet+kind setup #1296

Conversation

denis-tingaikin
Copy link
Member

@denis-tingaikin denis-tingaikin commented May 18, 2022

Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com

Description

this patch simply moves the restore file to the shared dir that is totally safe for different clusters. Fixes a root cause when default dns is not working for the nsc on the packet+kind clusters.

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit dd9b496 into networkservicemesh:main May 18, 2022
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request May 18, 2022
…k@main

PR link: networkservicemesh/sdk#1296

Commit: dd9b496
Author: Denis Tingaikin
Date: 2022-05-18 18:48:56 +0300
Message:
  - fix path for the restoring resolv.config (#1296)
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants