Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data path healing should be disabled #1304

Merged

Conversation

ljkiraly
Copy link
Contributor

@ljkiraly ljkiraly commented Jun 1, 2022

Description

Do not set dst in IP context in case of singlepoint IPAM

Issue link

networkservicemesh/cmd-nsc#447

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: Laszlo Kiraly <laszlo.kiraly@est.tech>
Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@edwarnicke Do you have any comments?

@edwarnicke edwarnicke merged commit 74b8b0f into networkservicemesh:main Jun 2, 2022
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jun 2, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jun 3, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jun 3, 2022
…k@main

PR link: networkservicemesh/sdk#1304

Commit: 74b8b0f
Author: Laszlo Kiraly
Date: 2022-06-02 13:33:06 +0200
Message:
  - Data path healing should be disabled (#1304)
Related issue: cmd-nsc/447

Do not set dst in IP context in case of singlepoint IPAM

Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants