Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty dns answer #1344

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Handle empty dns answer #1344

merged 1 commit into from
Aug 31, 2022

Conversation

glazychev-art
Copy link
Contributor

Signed-off-by: Artem Glazychev artem.glazychev@xored.com

Description

If we run dig or nslookup with norec flag, these commands may return a positive result (NOERROR) but without Answer section. We must handle this situation.

Issue link

Closes: networkservicemesh/integration-k8s-packet#294

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@glazychev-art
Handle empty dns answer
d47fad8 
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
@denis-tingaikin denis-tingaikin merged commit ed5cc97 into networkservicemesh:main Aug 31, 2022
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
df4a275 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
489e0ab 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c7d1e54 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
544b530 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
638358c 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9387d96 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f0e280f 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9a155c6 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0309085 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f815477 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
93d6610 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Aug 31, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c6adb0b 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
@nsmbot nsmbot mentioned this pull request Aug 31, 2022
Merged
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Aug 31, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
566f8df 
…k@main

PR link: networkservicemesh/sdk#1344

Commit: ed5cc97
Author: Artem Glazychev
Date: 2022-08-31 16:42:38 +0700
Message:
  - Handle empty dns answer (#1344)
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Aug 31, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-tingaikin denis-tingaikin denis-tingaikin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestDNS and TestVl3_DNS are not stable
2 participants
@glazychev-art @denis-tingaikin