Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix linter issues after update golangci-lint version #1351

Merged
merged 1 commit into from
Sep 12, 2022
Merged

fix linter issues after update golangci-lint version #1351

merged 1 commit into from
Sep 12, 2022

Conversation

denis-tingaikin
Copy link
Member

Signed-off-by: Denis Tingaikin denis.tingajkin@xored.com

Description

Related to networkservicemesh/.github#15

Issue link

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin
fix linter issues
0688b06 
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
edwarnicke
edwarnicke reviewed Sep 12, 2022
View reviewed changes
pkg/networkservice/chains/endpoint/combine.go
// * networkservice.ConnectionEventType_INITIAL_STATE_TRANSFER is merged to single event from all endpoints
// * rest events just go with no changes from all endpoints
// - networkservice.ConnectionEventType_INITIAL_STATE_TRANSFER is merged to single event from all endpoints
// - rest events just go with no changes from all endpoints
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious... what linting is failing here?

edwarnicke
edwarnicke approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@edwarnicke edwarnicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edwarnicke edwarnicke merged commit 2385d2c into main Sep 12, 2022
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6df7b1b 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
e9e0bbd 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
9fd6605 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
03f265e 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
92295bd 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
16e4a1d 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
5b91780 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d3becc4 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c17edf3 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
0d86d4f 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
bcbb3d7 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Sep 12, 2022
Update go.mod and go.sum to latest version from networkservicemesh/sd…
92471d6 
…k@main

PR link: networkservicemesh/sdk#1351

Commit: 2385d2c
Author: Denis Tingaikin
Date: 2022-09-12 20:59:24 +0300
Message:
  - fix linter issues (#1351)
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Sep 12, 2022
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke edwarnicke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denis-tingaikin @edwarnicke