dns fanout: wrap IPv6 address #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
requested review from
denis-tingaikin,
NikitaSkrynnik and
edwarnicke
| @@ -55,6 +56,11 @@ func (h *fanoutHandler) ServeDNS(ctx context.Context, rw dns.ResponseWriter, msg | |||
| Timeout: timeout, | |||
| } | |||
|
|
|||
| // If u.Host is IPv6 then wrap it in brackets | |||
| if strings.Count(u.Host, ":") >= 2 && !strings.HasPrefix(u.Host, "[") && !strings.Contains(u.Host, "]") { | |||
| u.Host = fmt.Sprintf("[%s]", u.Host) | |||
There was a problem hiding this comment.
Can we apply this foraddress variable from line 64?
There was a problem hiding this comment.
Unfortunately no. We need line 65.
url.Port() validates the value when calculating the port. And it looks at brackets.
So we need to modify u.Host
NikitaSkrynnik
approved these changes
Nov 15, 2022
denis-tingaikin
approved these changes
Dec 15, 2022
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Dec 15, 2022
…k@main PR link: networkservicemesh/sdk#1374 Commit: fa94b07 Author: Artem Glazychev Date: 2022-12-15 16:54:44 +0700 Message: - dns fanout: wrap IPv6 address (#1374) Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 15, 2022
This was referenced Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com
Description
Issue link
networkservicemesh/integration-k8s-aws#324
How Has This Been Tested?
Types of changes