begin: update eventFactory context based on the initial one #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
force-pushed
the
begin_postpone
branch
4 times, most recently
from
34b8abd
to
a6a462f
Compare
glazychev-art
force-pushed
the
begin_postpone
branch
2 times, most recently
from
7b46db5
to
fbb4bb2
Compare
NikitaSkrynnik
approved these changes
Nov 23, 2022
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
begin_postpone
branch
from
fbb4bb2
to
e23cdb7
Compare
denis-tingaikin
approved these changes
Dec 13, 2022
|
@edwarnicke Could you also have a look into that? |
|
@glazychev-art Could you rebase this on the latest main and check that tests are working? |
|
@denis-tingaikin |
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 13, 2022
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Dec 13, 2022
…k@main PR link: networkservicemesh/sdk#1375 Commit: bb4ba1a Author: Artem Glazychev Date: 2022-12-14 01:25:56 +0700 Message: - begin: update eventFactory context based on the initial one (#1375) * begin: update eventFactory context based on the initial one Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> * Replace assert with require Signed-off-by: Artem Glazychev <artem.glazychev@xored.com> Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com
Description
In the current implementation, we update the
eventFactorycontext after a successful request.This is not quite right, because in addition to updating the context values, we also update the request timeout. It is calculated on the wayback.
For example, the request came with a timeout of 15s and took 5s. For the event factory, we calculate 10s, but we need 15s.
Issue link
How Has This Been Tested?
Types of changes