Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qfix: code-cov matrix strategy is incorrect #1410

Merged
merged 1 commit into from
Jan 17, 2023
Merged

qfix: code-cov matrix strategy is incorrect #1410

merged 1 commit into from
Jan 17, 2023

Conversation

denis-tingaikin
Copy link
Member

Signed-off-by: denis-tingaikin denis.tingajkin@xored.com

Issue link

https://github.com/networkservicemesh/sdk/actions/runs/3870235535

How Has This Been Tested?

  • Added unit testing to cover
  • Tested manually
  • Tested by integration testing
  • Have not tested

Types of changes

  • Bug fix
  • New functionallity
  • Documentation
  • Refactoring
  • CI

@denis-tingaikin denis-tingaikin changed the title qfi:x code-cov matrix strategy is incorrect qfix: code-cov matrix strategy is incorrect Jan 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@1492e69). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1410   +/-   ##
=======================================
  Coverage        ?   67.85%           
=======================================
  Files           ?      267           
  Lines           ?    11611           
  Branches        ?        0           
=======================================
  Hits            ?     7879           
  Misses          ?     3228           
  Partials        ?      504

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denis-tingaikin denis-tingaikin marked this pull request as ready for review January 10, 2023 16:42
@denis-tingaikin
fix matrix for code-cov
d60cb90 
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
@edwarnicke edwarnicke merged commit 57af827 into main Jan 17, 2023
nsmbot pushed a commit to networkservicemesh/cmd-ipam-vl3 that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1445d65 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-cluster-info-k8s that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
f1b4210 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-admission-webhook-k8s that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d986c77 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-map-ip-k8s that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
3249ecd 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-kernel that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
24f055d 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-vfio that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
76982df 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
1eb637b 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/sdk-k8s that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
305bae7 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsc-init that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
6d7d537 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-proxy-dns that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
a82eebc 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nse-remote-vlan that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
d32f701 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-registry-memory that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
c8e621e 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot pushed a commit to networkservicemesh/cmd-nsmgr-proxy that referenced this pull request Jan 17, 2023
Update go.mod and go.sum to latest version from networkservicemesh/sd…
92600e8 
…k@main

PR link: networkservicemesh/sdk#1410

Commit: 57af827
Author: Denis Tingaikin
Date: 2023-01-17 17:38:15 +0300
Message:
  - fix matrix for  code-cov (#1410)
Signed-off-by: denis-tingaikin <denis.tingajkin@xored.com>
Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Jan 17, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@nsmbot nsmbot mentioned this pull request Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwarnicke edwarnicke edwarnicke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denis-tingaikin @codecov-commenter @edwarnicke