-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding stack to errors #1413
Adding stack to errors #1413
Conversation
70ff94a
to
ef0c48e
Compare
ef0c48e
to
65a85f5
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
=======================================
Coverage ? 67.60%
=======================================
Files ? 267
Lines ? 11625
Branches ? 0
=======================================
Hits ? 7859
Misses ? 3257
Partials ? 509 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
17770b7
to
0f5a54f
Compare
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
0f5a54f
to
4f8be35
Compare
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
4f8be35
to
2d18192
Compare
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
04f2e44
to
b6301b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it looks good to me.
Left a couple of comments
@@ -1,4 +1,4 @@ | |||
// Copyright (c) 2020-2022 Cisco and/or its affiliates. | |||
// Copyright (c) 2020-2023 Cisco and/or its affiliates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unnecessary change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx, done
@@ -47,7 +47,7 @@ func NewMonitorConnectionMonitorConnectionsClient(ctx context.Context, eventCh < | |||
func (m *monitorConnectionMonitorConnectionsClient) Recv() (*networkservice.ConnectionEvent, error) { | |||
select { | |||
case <-m.ctx.Done(): | |||
return nil, m.ctx.Err() | |||
return nil, errors.WithStack(m.ctx.Err()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be "application context is done"
(and other places like m.ctx.Err()
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, done
ea64870
to
ea1b01f
Compare
Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
…k@main PR link: networkservicemesh/sdk#1413 Commit: 3aa9aa0 Author: Ruslan Bayandinov Date: 2023-02-13 19:45:19 +0600 Message: - Adding stack to errors (#1413) * adding stack to errors Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update generated files Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/ipam Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/networkservice Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/registry Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update errors handling in pkg/tools Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * update context errors handling Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> * address review comments Signed-off-by: Ruslan Bayandinov <wazsone@ya.ru> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
Description
Make sure that all errors have a stack and message
Before:
After:
Issue link
#705
How Has This Been Tested?
Types of changes